Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Minor frontend issues #2153

Draft
wants to merge 4 commits into
base: pre/2.8
Choose a base branch
from

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Jan 10, 2025

  • PointDipole docs
  • Pipeline overflow issue possible fix. Sporadic so it is hard to test. We've decided to fix this from the backend.
    • ~Introduced constant value in boto3.config ~
    • Need to check if necessary for requests~
  • Remove version from API docs.

So the problem is:

WARNING:urllib3.connectionpool:Connection pool is full, discarding connection: flow360studio.s3.us-gov-west-1.amazonaws.com. Connection pool size: 10

So the pipeline overflow issue can be related to this

However, it seems to be an environment issue from the local testing so far (and that I've not been able to reproduce it with the current pre/2.8 environment?).

@daquinteroflex daquinteroflex changed the base branch from develop to pre/2.8 January 10, 2025 10:17
@daquinteroflex daquinteroflex force-pushed the dario/2.8/minor_frontend_issues branch from 8be38cf to 9bead75 Compare January 14, 2025 16:04
@daquinteroflex daquinteroflex mentioned this pull request Jan 21, 2025
@abdelq
Copy link

abdelq commented Feb 5, 2025

FYI, adding the following

config=botocore.config.Config(
  max_pool_connections=42,  # A sensible default should be picked
)

in

return boto3.client(
"s3",
region_name=Env.current.s3_region,
aws_access_key_id=self.user_credential.access_key_id,
aws_secret_access_key=self.user_credential.secret_access_key,
aws_session_token=self.user_credential.session_token,
verify=Env.current.ssl_verify,
)
is how we fixed the same warning.

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Feb 5, 2025

Thanks @abdelq , glad that worked for you!

We're working on fixing this at the server webpoint level as to maximise the amount of connections that we can open without these warnings. I'll update here when this is implemented without needing to change the boto3 configuration at the user api level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants