Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error if far_field_approx=False enabled for 2D simulations. #2293

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Raise an error if far_field_approx=False enabled for 2D simulations. #2293

merged 1 commit into from
Mar 5, 2025

Conversation

QimingFlex
Copy link
Contributor

No description provided.

@QimingFlex QimingFlex requested a review from momchil-flex March 4, 2025 15:39
@QimingFlex QimingFlex force-pushed the qiming/error_far_monitor_2d branch from 671ccd2 to cced995 Compare March 4, 2025 18:06
momchil-flex
momchil-flex approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QimingFlex! Just a tiny syntax note.

@QimingFlex QimingFlex force-pushed the qiming/error_far_monitor_2d branch from cced995 to 4a274b6 Compare March 5, 2025 16:44
@QimingFlex QimingFlex merged commit b9a857e into pre/2.8 Mar 5, 2025
15 checks passed
@QimingFlex QimingFlex deleted the qiming/error_far_monitor_2d branch March 5, 2025 19:34
@momchil-flex momchil-flex mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QimingFlex @momchil-flex