Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a minimum refactor of optimizer and design region #2299

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

a minimum refactor of optimizer and design region #2299

wants to merge 1 commit into from
+121 −89

Conversation

tylerflex
Copy link
Collaborator

just a sketch

  1. every InverseDesign has a list of design regions.
  2. Optimizer now is the container for the entire optimization.
  3. Each design region has an OptimizationSpec, corresponding to specifics of optimization updates.

to do potentially:
combine InverseDesign and INverseDesignMulti into one class, handle simulations as a list always but maybe provide nicer api

@tylerflex tylerflex marked this pull request as draft March 7, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groberts-flex groberts-flex Awaiting requested review from groberts-flex

@yaugenst-flex yaugenst-flex Awaiting requested review from yaugenst-flex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tylerflex