Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner filtering in LayerRefinementSpec #2303

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix corner filtering in LayerRefinementSpec #2303

wants to merge 1 commit into from
+12 −7

Conversation

weiliangjin2021
Copy link
Collaborator

No description provided.

@weiliangjin2021 weiliangjin2021 added the Bug something isnt working label Mar 10, 2025
lucas-flexcompute
lucas-flexcompute approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't usually like double negatives... it'd be clearer (in my opinion) to have this as _is_inplane_bounded. This being a private method, you might be allowed to change it. This is just my opinion, though.

@weiliangjin2021
Copy link
Collaborator Author

I don't usually like double negatives... it'd be clearer (in my opinion) to have this as _is_inplane_bounded. This being a private method, you might be allowed to change it. This is just my opinion, though.

Good point, I'll change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-flexcompute lucas-flexcompute lucas-flexcompute approved these changes

Assignees
No one assigned
Labels
Bug something isnt working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiliangjin2021 @lucas-flexcompute