Default strict=false in production

flippercloud · Dec 5, 2023 · 443742b · jnunemaker · Dec 5, 2023 · 443742b
1 parent 54ccbc2
commit 443742b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/flipper/engine.rb b/lib/flipper/engine.rb
@@ -73,6 +73,8 @@ def default_strict_value
         value.to_sym
       elsif value
         Typecast.to_boolean(value) ? :raise : false
+      elsif Rails.env.production?
+        false
       else
         # Warn for now. Future versions will default to :raise in development and test
         :warn

diff --git a/spec/flipper/engine_spec.rb b/spec/flipper/engine_spec.rb
@@ -57,7 +57,14 @@
       end
     end
 
-    %w(development test production).each do |env|
+    it "defaults to strict=false in RAILS_ENV=production" do
+        Rails.env = "production"
+        subject
+        expect(config.strict).to eq(false)
+        expect(adapter).to be_instance_of(Flipper::Adapters::Memory)
+    end
+
+    %w(development test).each do |env|
       it "defaults to strict=warn in RAILS_ENV=#{env}" do
         Rails.env = env
         expect(Rails.env).to eq(env)
@@ -160,7 +167,6 @@
 
     it_behaves_like 'config.strict' do
       let(:adapter) do
-        puts "WAT?"
         dual_write = Flipper.adapter.adapter
         poll = dual_write.local
         poll.adapter