New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: Plantain parser Last payment amount fix #3998

Open

mxcdoam wants to merge 1 commit into flipperdevices:dev from mxcdoam:Plntn_fix

+10 −6

Contributor

mxcdoam commented Nov 12, 2024

What's new

The current parser shows the correct result for "last payment amount" only if the top up amount was 3 digits long, if it is longer - the parser shows incorrect value instead of the real amount. This should fix this issue for top ups highter than 999 RUB.

Verification

Compile plantain_parser.fal with ./fbt fap_dist, then put it in /apps_data/nfc/plugins. Run the NFC app and read a plantain card which was topped up for >=1000 RUB.

Checklist (For Reviewer)

PR has description of feature/bug or link to Confluence/Jira task
Description contains actions to verify feature/bugfix
I've built this code, uploaded it to the device and verified feature/bugfix


          Fix Last payment amount fix

5986fe0

mxcdoam requested review from skotopes, DrZlo13, hedger, gsurkov, gornekich and Astrrra as code owners

November 12, 2024 16:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skotopes Awaiting requested review from skotopes skotopes is a code owner

DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

hedger Awaiting requested review from hedger hedger is a code owner

gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

gornekich Awaiting requested review from gornekich gornekich is a code owner

Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet