Dev#1
Draft
gdadunashvili wants to merge 60 commits into
Draft
Conversation
# Conflicts: # docs/_monte_carlo_updater_8hpp.html # docs/_monte_carlo_updater_8hpp__incl.map # docs/_monte_carlo_updater_8hpp__incl.md5 # docs/_monte_carlo_updater_8hpp__incl.png # docs/_triangulation_8hpp.html # docs/_triangulation_8hpp__incl.map # docs/_triangulation_8hpp__incl.md5 # docs/_triangulation_8hpp__incl.png # docs/_triangulator_8hpp.html # docs/_triangulator_8hpp__incl.map # docs/_triangulator_8hpp__incl.md5 # docs/_triangulator_8hpp__incl.png # docs/classfp_1_1_monte_carlo_updater.html # docs/classfp_1_1_monte_carlo_updater_ac3e40c3b93bf2bf6f2b08291357503be_cgraph.map # docs/classfp_1_1_monte_carlo_updater_ac3e40c3b93bf2bf6f2b08291357503be_cgraph.md5 # docs/classfp_1_1_monte_carlo_updater_ac3e40c3b93bf2bf6f2b08291357503be_cgraph.png # docs/classfp_1_1_triangulation.html # docs/classfp_1_1_triangulation_a692685c96cd6a0cdba72b50adf3fb49b_cgraph.map # docs/classfp_1_1_triangulation_a692685c96cd6a0cdba72b50adf3fb49b_cgraph.md5 # docs/classfp_1_1_triangulation_a692685c96cd6a0cdba72b50adf3fb49b_cgraph.png # docs/classfp_1_1_triangulation_aaef436fe4758c409b21a135b329edc17_cgraph.map # docs/classfp_1_1_triangulation_aaef436fe4758c409b21a135b329edc17_cgraph.md5 # docs/classfp_1_1_triangulation_aaef436fe4758c409b21a135b329edc17_cgraph.png # docs/classfp_1_1_triangulation_ad8102adbe7dab80cda3209844a939e30_cgraph.map # docs/classfp_1_1_triangulation_ad8102adbe7dab80cda3209844a939e30_cgraph.md5 # docs/classfp_1_1_triangulation_ad8102adbe7dab80cda3209844a939e30_cgraph.png # docs/flippy_8hpp.html # docs/flippy_8hpp__incl.map # docs/flippy_8hpp__incl.md5 # docs/flippy_8hpp__incl.png
cot_between_vectors is antisymmetric, which can be used to simplify the expression
this function runs in hot loops, and the reduction of allocations significantly improves the performance
this function just checks if the number of common neighbors is two without having to remember what the common neighbors are which was not actually required by the triangulation
Instead of finding common neighbors and checking if there are two, we now just check if there are two, not remembering already checked neighbors. in the bond flip routine for closed topologies we also omit the first check, since we know a valid triangulation before a flip will always have a correct number of neighbours
it's not really necessary and it's absence has no adverse effects on the performance
single header flippy and docs
factored out double literal into REAL and changed double to float
proper parsing of save_dir and benchmark_version
for utils
rest of the code is not adapted yet in this commit, will be part of the next commit
allso finalized the stripping out of unit_bending_energy
Abs close is used only when comparing against 0
appending new line here leads to ill formed xyz files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.