ensure chain exists in networksMeta (#1476)

* ensure chain exists in networksMeta * destructure * add additional test cases * dont overwrite existing metadata --------- Co-authored-by: Matt Holtzman <[email protected]>
floating · Mar 7, 2023 · ced11a3 · ced11a3
1 parent e5cd876
commit ced11a3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/main/store/migrations/index.js b/main/store/migrations/index.js
@@ -887,12 +887,16 @@ const migrations = {
     Object.values(initial.main.networks.ethereum).forEach((network) => {
       const { id } = network
       const { name = '', symbol = '' } = nativeCurrencyMap[id] || {}
-      const nativeCurrency = initial.main.networksMeta.ethereum[id].nativeCurrency
+      const existingMeta = initial.main.networksMeta.ethereum[id] || {}
+      const { nativeCurrency = {} } = existingMeta
 
-      initial.main.networksMeta.ethereum[id].nativeCurrency = {
-        ...nativeCurrency,
-        name: nativeCurrency.name || name,
-        symbol: nativeCurrency.symbol || symbol
+      initial.main.networksMeta.ethereum[id] = {
+        ...existingMeta,
+        nativeCurrency: {
+          ...nativeCurrency,
+          name: nativeCurrency.name || name,
+          symbol: nativeCurrency.symbol || symbol
+        }
       }
     })
 

diff --git a/test/main/store/migrations/index.test.js b/test/main/store/migrations/index.test.js
@@ -1421,4 +1421,19 @@ describe('migration 34', () => {
       expect(getNativeCurrency(updatedState, 56)[field]).toBe('')
     })
   })
+
+  it('should set native currency data when no chain metadata previously existed', () => {
+    state.main.networks.ethereum[10] = { id: 10 }
+
+    const updatedState = migrations.apply(state, 34)
+    expect(getNativeCurrency(updatedState, 10)).toStrictEqual({ name: 'Ether', symbol: 'ETH' })
+  })
+
+  it('should set native currency data when none previously existed', () => {
+    createChainState(137)
+    delete state.main.networksMeta.ethereum[137].nativeCurrency
+
+    const updatedState = migrations.apply(state, 34)
+    expect(getNativeCurrency(updatedState, 137)).toStrictEqual({ name: 'Matic', symbol: 'MATIC' })
+  })
 })