fix(config): better config parse errors#1691
Merged
andrinoff merged 2 commits intoJul 24, 2026
Merged
Conversation
- Wrap the JSON parse error in LoadConfig with the config file path so users know which file has the problem (fixes floatpane#1520). - Replace panic on malformed embedded default_keybinds.json with a logged warning that returns empty keybinds, preventing a crash from corrupted embedded data.
floatpanebot
previously requested changes
Jul 20, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @kawacukennedy! Please fix the following issues with your PR:
- Title: Is too long (69 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
kawacukennedy
changed the title
floatpanebot
dismissed
their stale review
July 20, 2026 01:33
Formatting issues have been resolved. Thank you!
andrinoff
approved these changes
Jul 24, 2026
floatpanebot
pushed a commit
that referenced
this pull request
Jul 24, 2026
## What? Wrap config file parse errors with the file path, and replace the `panic()` in `defaultKeybinds()` with a logged warning. ## Why? Closes #1520 When a config file is malformed, the error only showed a raw JSON parse error with no indication of which file was broken. Users had no way to know what to fix. If the embedded `default_keybinds.json` was somehow corrupted, the application crashed with a panic instead of degrading gracefully. --------- Co-authored-by: kawacukennedy <kennedykawacu@gmail.com> (cherry picked from commit ed44a8f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Wrap config file parse errors with the file path, and replace the
panic()indefaultKeybinds()with a logged warning.Why?
Closes #1520
When a config file is malformed, the error only showed a raw JSON parse error with no indication of which file was broken. Users had no way to know what to fix.
If the embedded
default_keybinds.jsonwas somehow corrupted, the application crashed with a panic instead of degrading gracefully.