Allow invalid regs #111
Merged
Allow invalid regs #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll try to look in detail into the PR 'soon-ish'... In the meantime, don't mind the CI errors, looks like those are unrelated to your PR (I guess trying to use designated initialization in the C++ code was a mistake lol - not sure why those problems haven't shown up earlier though). |
|
Yeah I saw that some passed and thought the errors shouldn't be related to my changes. |
|
Ok, finally got around to merge this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This thread at World of Spectrum says that it's valid to write to invalid AY registers, and that you can read back the value, which decays over time.
This PR doesn't implement the decay, but makes it possible to set the register address to an invalid one, and makes reading back from it return 0, as if it instantly decays.
I made this change because there's this SZX snapshot that has the last AY register address set to 16, and it was causing an assert. Instead of making it a special case in my code, I thought it would be nice if it was at least partially implemented in
ay38910.h.