Spanish website translation + Hability to localize the site #2

delthia · 2022-09-07T18:54:29Z

As talked in #1, this adds the spanish translation of the site, and all the needed configuration for the site to be more easily translated, including a simple language switcher.

Signed-off-by: delthia <[email protected]>

patrickgold

Thanks a lot for your work, really appreciate it!

I've now extensively read through your changes and reviewed them. They are very good and it already looks very nice, kudos to your work! I have just added some comments for fine-tuning and code quality/consistency, and one comment for a small logic issue.

A tip for the formatting: This project includes an .editorconfig, which configures your IDE to use the correct format for text files (at least at the base level). I don't know which IDE you use but many editors support this file, natively or via extension, and it helps a lot keeping the format automatically clean.

patrickgold · 2022-09-07T20:57:28Z

config/_default/config.toml

+assetDir = "src"
+enableRobotsTXT = true
+
+title = "FlorisBoard"


Missing empty line at the end (this is a convention I use throughout all my projects, because it allows to print a file in the terminal quickly without messed up formats).

patrickgold · 2022-09-07T20:57:43Z

config/_default/translations/languages.en.toml

+footer = "For more information and download options check out the GitHub repo!"
+modificated = "Last modified:"
+florisboard-icon = "FlorisBoard app icon"
+florisboard-screenshot = "FlorisBoard screenshot"


Same here, missing empty line at the end

patrickgold · 2022-09-07T20:57:48Z

config/_default/translations/languages.es.toml

+footer = "¡Para más información y opciones de descarga echa un vistazo al repositorio de GitHub!"
+modificated  = "Modificado por última vez el"
+florisboard-icon = "Icono de la aplicación FlorisBoard"
+florisboard-screenshot = "Captura de pantalla de FlorisBoard"


Same here, missing empty line at the end

patrickgold · 2022-09-07T20:59:09Z

config/_default/config.toml

@@ -0,0 +1,8 @@
+# baseURL = "https://florisboard.org/"
+baseURL = "https://f.delthia.com/"
+defaultContentLanguage = 'en'


I suggest using a double quote for the en-string, to be in line with the other strings in the config.

patrickgold · 2022-09-07T20:59:50Z

config/_default/config.toml

@@ -0,0 +1,8 @@
+# baseURL = "https://florisboard.org/"
+baseURL = "https://f.delthia.com/"


For testing this is OK, but we must not forget changing this back to the florisboard.org domain before merging in.

Maybe this could be made to work by having a different action when it is in a fork or on another branch, I haven't much experience with that, but if I find a simple way to make it work like that, maybe it would be easier if people contribute translations.

Hmm I don't really know if an action can be configured to run with different params tbh, and even then how do you configure this param without having to commit it to the fork?

patrickgold · 2022-09-07T21:01:10Z

layouts/404.html

@@ -1,3 +1,3 @@
 {{ define "main" }}
-<p style="color: red;">The requested resource could not be found. Please check the address and try again.</p>
+<p style="color: red;">{{ .Param "not-found" }}</p>


I am not sure, but can't one use {{ i18n "string_name" }} for referencing strings in Hugo? If so I think using this would be best, as it is immediately clear that this variable is a translatable variable.

(if it is possible to use the i18n syntax this comment is valid for all usage sites, but I won't comment individually on all occurrences)

I did it that way because it was the quickest I found, as I haven't much experience with the multilang part of hugo, but now that the translations where splitted into diferent files, I think it would be feasible to use the i18n syntax after I look into it.

patrickgold · 2022-09-07T21:03:39Z

layouts/_default/single.html

@@ -1,5 +1,5 @@
 {{ define "main" }}
 <h1>{{ .Title }}</h1>
-{{ with .Lastmod }}<p class="last-modified">Last modified: {{ . | time.Format ":date_medium" }}</p>{{ end }}
+<p class="last-modified">{{ .Param "modificated" }} {{ with .Lastmod }}{{ . | time.Format ":date_medium" }}</p>{{ end }}


Here you moved the {{ with .Lastmod }} block inwards, causing half of the last mod paragraph to always be included. It should be before the paragraph element, so it either includes the whole localized paragraph or not at all if the lastmod attribute is not defined.

I'll have to look a bit more into this, as I changed it because otherwise the translation variable would work. It does make sense like that, but as currently the site only has a single page that does contain the lastmod tag, I didn't think about that.

delthia · 2022-09-07T21:23:01Z

Thanks a lot for your work, really appreciate it!

I've now extensively read through your changes and reviewed them. They are very good and it already looks very nice, kudos to your work! I have just added some comments for fine-tuning and code quality/consistency, and one comment for a small logic issue.

Thanks for that, I just read through them, but tomorrow I'll go through them in more depth to fix them,

A tip for the formatting: This project includes an .editorconfig, which configures your IDE to use the correct format for text files (at least at the base level). I don't know which IDE you use but many editors support this file, natively or via extension, and it helps a lot keeping the format automatically clean.

Well, when it comes to that, I am a bit all over the place, I used to use atom, and I've recently changed to vscodium, but I also use vim, in reality I don't get along to well with IDEs, and I end up just using them as code editors and have a few terminals, as I mostly work with small python and bash scripts. Thanks for the tip! I should look into that, because atom did add the extra line at the end.

delthia · 2022-10-07T12:18:48Z

Hi,
I've fixed the issues you mentioned, so now the translations are stored in the i18n directory and pulled with {{ i18n "translation-key" }}. I've also kept the separate configuration files for the different languages because I think it could be easier to just copy, rename and change the file according to the language that is being translated rather than copying and pasting the sections.
I also fixed the issue you mentioned with the last-modified logic and added the end of file lines.

patrickgold

Hey delthia,

thanks a lot for addressing the mentioned issues!

I've reviewed the changes and the i18n management is now really cool and machine-accessible, so it can at some point easily be integrated into a translation service. I agree with you that putting language-specific configs in their own file is a good option.

So the only issue I now see is that the language switcher can look janky on mobile pages on small screens, however I think this can be fixed in the future by another PR, especially as the "Visit GH" link needs a rework too at some point.

So if you don't have anything to add I think this PR is merge-ready, great work :) Only thing we must not forget is to change the base URL back to florisboard.org before merging.

delthia · 2022-10-09T07:40:17Z

Hi,
I changed the domain name in the config file.
I agree that the language switcher is not great, as it doesn't always align correcly. It is something that I have to work on, but I agree that it can be done in another PR.
When it comes to translation platforms, I think it would be great to get that working at some point. Regarding translation platforms, I know crowding, as it is what the main project is using, and I've worked a bit with weblate. Whenever you feel like it should be added, I don't mind looking into that.

patrickgold

Thanks a lot for the fixes!

I now tested your changes locally and everything works like a charm. Only thing I found was that the link to the wiki page is broken within the Spanish version of the privacy policy (see comment). Once you accept the suggested change I will merge your changes in.

content/es/legal/privacy.md

patrickgold · 2022-10-09T20:43:00Z

Regarding translation platforms, I know crowding, as it is what the main project is using, and I've worked a bit with weblate. Whenever you feel like it should be added, I don't mind looking into that.

I think I will use Crowdin for the website as well. It would make sense at least, as the main project is also using Crowdin. But atm my head is too full that I can focus on this integration, as I need to focus on my word suggestions project, which is moving a lot slower than I want sadly.

Co-authored-by: Patrick Goldinger <[email protected]>

delthia · 2022-10-09T20:50:27Z

I've just accepted the changes, so everything is ready.
As we talked, fixing the language selector dropdown remains pending, so when I've the time I'll try to fix it.

as I need to focus on my word suggestions project

I hope it goes well with that project, as I really like the keyboard and that is a great feature.

Thanks again for the project, I'll keep an eye around for when I can help with the page, as it the area I can help in.

patrickgold

Thanks for the changes, will now merge in your changes!

delthia added 14 commits September 1, 2022 23:13

Start adding Spanish translation

462cda9

Add Spanish translation and prepare site for translations

1985fc4

404 translation

9e470a4

Signed-off-by: delthia <[email protected]>

Domain config for preview site

413ee04

Add domain for preview

14b91ba

Change to directory-based translation

eeb14f2

Move to directory-based configuration

75ffbb3

Translate last updated

fb4331c

Delete file based translation for index

605b8b4

Start implementing language selector - Bad styling

b6dcd2e

Style language dropdown

a8e4a8b

Make language switcher work correctly

46a39da

Fix typo

abfce10

Localize image descriptions and frontpage image

02effc8

patrickgold requested changes Sep 7, 2022

View reviewed changes

delthia added 3 commits September 8, 2022 08:37

Fix formatting

af7e663

Change to i18n translations

cc5001e

Add EndOfFile blank lines

60f4479

patrickgold reviewed Oct 9, 2022

View reviewed changes

Change domain name before merging

059f6de

delthia added 2 commits October 9, 2022 11:51

Move description to translation file

982783c

Remove test domain from config file

6350759

patrickgold requested changes Oct 9, 2022

View reviewed changes

content/es/legal/privacy.md Outdated Show resolved Hide resolved

Fix wiki link for spanish privacy policy

8b97ca1

Co-authored-by: Patrick Goldinger <[email protected]>

patrickgold approved these changes Oct 13, 2022

View reviewed changes

patrickgold merged commit d5b12fe into florisboard:main Oct 13, 2022

Thithic mentioned this pull request Nov 3, 2022

Change layout to fix language selector #3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spanish website translation + Hability to localize the site #2

Spanish website translation + Hability to localize the site #2

delthia commented Sep 7, 2022

patrickgold left a comment

patrickgold Sep 7, 2022

patrickgold Sep 7, 2022

patrickgold Sep 7, 2022

patrickgold Sep 7, 2022

patrickgold Sep 7, 2022

delthia Sep 8, 2022

patrickgold Sep 8, 2022

patrickgold Sep 7, 2022 •

edited

Loading

delthia Sep 8, 2022

patrickgold Sep 7, 2022

delthia Sep 7, 2022

delthia commented Sep 7, 2022

delthia commented Oct 7, 2022

patrickgold left a comment

delthia commented Oct 9, 2022

patrickgold left a comment

patrickgold commented Oct 9, 2022

delthia commented Oct 9, 2022

patrickgold left a comment

		@@ -0,0 +1,8 @@
		# baseURL = "https://florisboard.org/"
		baseURL = "https://f.delthia.com/"

Spanish website translation + Hability to localize the site #2

Spanish website translation + Hability to localize the site #2

Conversation

delthia commented Sep 7, 2022

patrickgold left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickgold Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

delthia commented Sep 7, 2022

delthia commented Oct 7, 2022

patrickgold left a comment

Choose a reason for hiding this comment

delthia commented Oct 9, 2022

patrickgold left a comment

Choose a reason for hiding this comment

patrickgold commented Oct 9, 2022

delthia commented Oct 9, 2022

patrickgold left a comment

Choose a reason for hiding this comment

patrickgold Sep 7, 2022 •

edited

Loading