Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added French translation #4

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Added French translation #4

merged 1 commit into from
Jan 13, 2023

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Jan 13, 2023 •
edited
Loading

Hello,
As my contribution to #1, I translated the site to French (was pretty easy technically speaking, thanks for the good work!).

I'm a big fan of FlorisBoard, and I hope a translated homepage can attract more francophone users 😄

Website preview (will be taken down after this PR will be merged/closed)

patrickgold
patrickgold approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@patrickgold patrickgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution, really appreciate it!

I've reviewed your changes and translations and everything checks out fine, will merge the changes in :)

@patrickgold patrickgold merged commit 2b061c4 into florisboard:main Jan 13, 2023
@nathanaelhoun nathanaelhoun deleted the i18n-french branch January 13, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickgold patrickgold patrickgold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanaelhoun @patrickgold