Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to umd #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Undergrounder
Copy link

Closes #12

Before creating a new release, it's necesary to run "grunt" and commit the files in the "dist" folder.

@Undergrounder
Copy link
Author

It's for allowing the library to be compatible with all module loaders and the browser.

With this change the library is compatible with CommonJS, AMD and the browser.
It also makes the dependency management easier as webpack injects all the dependencies in the correct order.

@AidasK
Copy link
Member

AidasK commented Jan 26, 2016

In the old version of fusty-flow.js we don't have dist folder, so this would be a breaking change. But for simplicity, we can release this as 2.0.0.

@Undergrounder
Copy link
Author

I agree with this.

If it's bether I could create the build files in /build and not in /dist

@AidasK
Copy link
Member

AidasK commented Jan 26, 2016

No, please keep them in dist, because we do this in all other repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants