Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query API] Location Query #1041

Open
LukasPietzschmann opened this issue Oct 8, 2024 · 4 comments · May be fixed by #1046
Open

[Query API] Location Query #1041

LukasPietzschmann opened this issue Oct 8, 2024 · 4 comments · May be fixed by #1046
Assignees
Labels
enhancement New feature or request query api relates to the query api

Comments

@LukasPietzschmann
Copy link
Collaborator

Query for the location of a specific Node (given by its ID)

@LukasPietzschmann LukasPietzschmann added enhancement New feature or request query api relates to the query api labels Oct 8, 2024
@LukasPietzschmann LukasPietzschmann self-assigned this Oct 8, 2024
@LukasPietzschmann LukasPietzschmann linked a pull request Oct 8, 2024 that will close this issue
@LukasPietzschmann
Copy link
Collaborator Author

@EagleoutIce how do you imagine the grouping to work? Should it be similar to call-context-query with kind and subkind?

@EagleoutIce
Copy link
Member

No, just return one result which contains a list of all requested vertices, essientially similar to the id-map but filered for the ids of interest.

@LukasPietzschmann
Copy link
Collaborator Author

Alright. But I think it would be better to return a map (id -> location) instead of a plain list of locations. This way, the client does not need to remember the order of the individual location-queries.

@EagleoutIce
Copy link
Member

this was what i meant with the second part, sorry :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request query api relates to the query api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants