[Query API] Location Query #1046
Open
+121
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grouping of locations will be implemented shortly :)
LukasPietzschmann
added
enhancement
|
Should i defer review until this is marked as ready? |
|
Yes please, the grouping is still completely missing. |
|
@EagleoutIce What do you think about adding a flag which, when set, will make the query return the |
|
I like the idea, but if so we should probably just generalize the fields you can query? maybe even rename this to 'node' or something and allow to filter for predefined keys like |
|
But if this is too much, outsource this to another issue and we focus on what you require here. |
EagleoutIce
reviewed
Oct 9, 2024
| return { | ||
| '.meta': { | ||
| /* there is no sense in measuring a get */ | ||
| timing: 0 |
There was a problem hiding this comment.
given there are multiple hashmap access operations, i would in-fact measure the time, as we are no longer constant!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.