Detect cargo-nextest as top-level cargo test runner #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accepts cargo-nextest as the top-level binary that drives a cargo testrun. This fixes the re-using of the numbered testdir between all the processeses started by a testrun under cargo-nextest. Probably.
Closed
Arqu
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Codewise LGTM, but I need to play more with it for any better response. Would be cool if @hellertime managed to check it out and test it out in his workflow.
|
👋 just got back to this after the US holiday. I updated my crate to use this branch, and it looks to have solved the issue. LGTM! |
|
thanks both for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accepts cargo-nextest as the top-level binary that drives a cargo
testrun. This fixes the re-using of the numbered testdir between all
the processeses started by a testrun under cargo-nextest. Probably.
Closes #4