Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate. The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users. Signed-off-by: Doug Whitfield <[email protected]>
lockewritesdocs
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks for your contribution @douglasawh! I suggested some editorial changes to incorporate.
This language much better than my original PR. All I *had* done is take what was in there, reformat it slightly, and move it to the top. Co-authored-by: Adam Locke <[email protected]> Signed-off-by: Doug Whitfield <[email protected]>
|
Hi @douglasawh, Thanks |
lecaros
added
waiting-for-user
douglasawh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate.
The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users.