Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CloudWatch plugin's required IAM permissions #1566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adis-io
Copy link

@adis-io adis-io commented Jan 29, 2025

Without this policy it won't be possible to use custom retention period

@adis-io adis-io requested review from a team as code owners January 29, 2025 10:17
@lecaros
Copy link
Contributor

lecaros commented Mar 17, 2025

@adis-io do you have a valid test case for this?
or a reference from the Cloudwatch's docs?

@adis-io
Copy link
Author

adis-io commented Mar 17, 2025

@adis-io do you have a valid test case for this? or a reference from the Cloudwatch's docs?

No, I don't have test case, I've just had this issue in my case

From AWS Docs:

When you create a log group, by default the log events in the log group do not expire. To set a retention policy so that events expire and are deleted after a specified time, use PutRetentionPolicy .

@@ -84,7 +84,8 @@ The following AWS IAM permissions are required to use this plugin:
"Action": [
"logs:CreateLogStream",
"logs:CreateLogGroup",
"logs:PutLogEvents"
"logs:PutLogEvents",
"logs:putRetentionPolicy"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the case important here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I've just noticed. It can be changed to PutRetentionPolicy for consistency

Signed-off-by: Adis Osmonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants