Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_logs_to_metrics: document field_value usage for counters #1584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

databus23
Copy link

This documents a feature added with this PR: fluent/fluent-bit#10055

This documents a feature added with this PR: fluent/fluent-bit#10055

Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @databus23, thanks for submitting a docs PR! I just suggested a few edits for clarity and consistency.

Co-authored-by: Alexa Kreizinger <alexakreizinger@gmail.com>
Signed-off-by: Fabian Ruff <fabian@progra.de>
@databus23
Copy link
Author

@alexakreizinger thanks for the feedback. I merged in all your suggestions.

Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you :) I'm approving this, but I won't merge anything since it sounds like we're still waiting on a different code PR—feel free to merge this one when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants