in_http: add_remote_addr #2130
Open
in_http: add_remote_addr #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
esmerel
reviewed
Nov 3, 2025
Contributor
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
My suggestions are stylistic for page consistency. They're fairly minor. This looks good to me otherwise, but should have a technical review for final approval.
Signed-off-by: Alexandre Létourneau <[email protected]>
aletourneau
force-pushed
the
in_http/add_remote_addr
branch
from
bc93bab to
867a1fb
Compare
patrick-stephens
approved these changes
Nov 5, 2025
Contributor
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
Seems ok, waiting on code merge.
patrick-stephens
removed
the
waiting-on-review
eschabell
added
4.2.1
conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to: fluent/fluent-bit#11080