out_datadog: Fix formatting issue when setting a static hostname#10104
Merged
edsiper merged 1 commit intofluent:masterfrom Mar 29, 2025
Merged
out_datadog: Fix formatting issue when setting a static hostname#10104edsiper merged 1 commit intofluent:masterfrom
edsiper merged 1 commit intofluent:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
Valgrind output: |
Contributor
Author
|
Debug output: |
4cc69e5 to
bc7f154
Compare
gh123man
approved these changes
Mar 19, 2025
…dd_hostname Signed-off-by: Ryan Hall <ryan.hall@datadoghq.com>
bc7f154 to
d38edc6
Compare
7 tasks
Member
|
@ddrthall is this ready to go ? |
Member
|
the fix looks good to me. merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Providing a static hostname via the dd_hostname configuration options is currently bugged, with an off-by-one error in the message packing loop causing dropped attributes and/or malformed output json. This PR corrects the issue, incrementing the msgpack map size by one when a dd_hostname property is detected.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
out_datadog: Fix formatting issue when setting a static hostname via dd_hostname (backport 3.2) #10138
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.