-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Increase MAX_EVENT_LEN to match current max #11159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe maximum event payload size limit for CloudWatch Logs is increased from 262118 bytes (256KiB minus 26) to 1048550 bytes (1MiB minus 26), with the corresponding documentation comment updated accordingly. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /* 1MiB minus 26 bytes for the event */ | ||
| #define MAX_EVENT_LEN 1048550 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow payload buffer to accommodate 1 MiB events
Raising MAX_EVENT_LEN to 1 048 550 means event->len + PUT_LOG_EVENTS_PER_EVENT_LEN now evaluates to 1 048 592 bytes. However, PUT_LOG_EVENTS_PAYLOAD_SIZE remains 1 048 576, so put_log_events() immediately treats any max-size message as “larger than our entire request buffer” and discards it before sending. As written, 1 MiB events still cannot be emitted despite the new constant. The payload limit or per-event overhead needs to be adjusted in tandem so a single event can fit into the request buffer.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on the adjustment to the max size in a follow-up
Summary
CloudWatch logs PutLogEvents API change in 2025 to support events up to 1MB (ref) while our defaults reflect the older value 256KB.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Gist: https://gist.github.com/ShelbyZ/76bfac405e03723efeb532a48d5b6a87
Over-limit on current logs
New limit
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit