upstream_conn: fix ordering of mk_event_inject and prepare_conn_destroy

[PettitWesley]

prepare_destroy_conn calls mk_list_del on the event in the priority bucket queue, so for safety, we inject it after this covers us against the case where the event was triggered and waiting, but we also reached the timeout.

Addresses this issue on 1.9: #6822

See the issue for a design doc on why this is needed

Signed-off-by: Wesley Pettit [email protected]

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

• Example configuration file for the change
• Debug log output from testing the change

• Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

• Run local packaging test showing all targets (including any new ones) build.
• Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

• Documentation required for this feature

Backporting

• Backport to latest stable release.

---

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

[patrick-stephens]

Looks like 1.9 branch also needs the updates to resolve the Github deprecation of set-output in workflows or ignore the linting failures for it (ActionLint is marking it as an error although it is not an actual failure until support for set-output is removed: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/).

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.