tests: add test for OpenTelemetry input plugin tagfromuri #8964
+138
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearpidgeon
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
nuclearpidgeon
force-pushed
the
opentelemetry-tagfromuri-tests
branch
from
ff8e352
to
8f165e0
Compare
Previous timeout was CMake default of 10000000s?? tests relying on timeout for failure would take... 3 months, 23 days, 17 hours, 46 minutes and 40 seconds (Source: https://calculat.io/en/date/seconds/10000000) Signed-off-by: Stewart Webb <[email protected]>
Signed-off-by: Stewart Webb <[email protected]>
nuclearpidgeon
force-pushed
the
opentelemetry-tagfromuri-tests
branch
from
8f165e0
to
75f1c9c
Compare
nuclearpidgeon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests for the OpenTelemetry input plugin's
tag_from_urifeature.Unfortunately if I remember correctly, not all these tests actually work for all signal types because there is still only partial support for JSON input.
I am hoping to update the tests with some gRPC / protobuf payloads but have yet to been able to work out a good way to do this - either need to use a gRPC commandline tool, or serialise some protobuf data into files for passing to cURL.
Developed while working on #8963 to address #8734.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.