-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiline: introduce static cri parser backend, providing 9mb/s performance gain over current regex cri parser #9418
Open
ryanohnemus
wants to merge
2
commits into
fluent:master
Choose a base branch
from
ryanohnemus:cri_parser_backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanohnemus <[email protected]>
ryanohnemus
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
September 24, 2024 16:58
ryanohnemus
force-pushed
the
cri_parser_backend
branch
from
September 25, 2024 12:21
e14075d
to
24261f4
Compare
Signed-off-by: ryanohnemus <[email protected]>
ryanohnemus
force-pushed
the
cri_parser_backend
branch
from
September 25, 2024 15:55
24261f4
to
d953463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #9399, I have been looking into performance improvements in fluent-bit. Specifically for apps in k8s that are creating many logs within a short amount of time (ie logging >15mb/s).
Test setup:
Hardware: GCP n2-standard-8 w/ ssd bootdisk
With config: (see full config in example config section)
multiline.parser: cri
(or any parser present) - i am able to achieve - 49.224Mb/s throughputmultiline.parser: cri
added to tail input above - throughput is 18.571Mb/smultiline.parser: cri
added to tail input above - throughput is 27.572Mb/s ~9mb/s gain by not using a regex parserImproving the multiline parsing speed should also considerably cut down on issues from log tail rotations (log rotations missed when fluentbit is backed up), since parsing is much more performant.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Using the k8s_perf_test from Performance Testing of Fluent-bit with several filters shows log processing falling < 5mb/s #9399 with the following service config:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation