in_node_exporter_metrics: fix size of core_throttles_set #9476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nux.c In core_throttles_set[n][m], n has size 32 only. On my PC, I have 44 cores and physical_package_id can have max value of 88. On line 140 we see: if (core_throttles_set[physical_package_id][core_id] != 0) This causes a segmentation fault as we access data from invalid address outside the range of buffer. The size is changed to 256 to accomodate high core count. Signed-off-by: Faran Abdullah [email protected] Signed-off-by: Faran Abdullah <[email protected]>
faran1512
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
faran1512
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nux.c
The issue is in ne_cpu_linux.c
In core_throttles_set[n][m], n has size 32 only.
On my PC, I have 44 cores and physical_package_id can have max value of 88.
On line 140 we see:
if (core_throttles_set[physical_package_id][core_id] != 0)
This accesses array at index 88, that has size of only 32.
This causes a segmentation fault.
Because we access data from invalid address outside the range of buffer.
Fix: The size is changed to 256 to accomodate high core count.
Signed-off-by: Faran Abdullah [email protected]
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.