-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add discard_logs_on_reconnect_error in asyncsender #176
base: master
Are you sure you want to change the base?
Conversation
5a23fd5
to
c7b7a70
Compare
I'll review it at depth when I have time, but I'm inclined not to accept this change. Unless I'm missing something the error should lead to a reconnect and resending of the logs. Clearing the queue will cause the loss of perfectly good logs due to a simple reconnect issue, which would not be acceptable. |
Yep Not problem. I understand it is risky Or maybe we should just print some logs to help the user for debug |
We can consider a tunable setting which would "discard logs on reconnect" and defaults to I tend to make decisions against arbitrary loss of data. |
Right. I can give a try. Thanks @arcivanov |
c7b7a70
to
44ba7a6
Compare
Signed-off-by: enjoy-binbin <[email protected]>
44ba7a6
to
6995dbb
Compare
@arcivanov |
issue: #175
When using asyncsender, there is a queue holds the logs to be send:
This is my solution, it doesn’t look particularly good. so feel free to close this if un-needed