fix: fix pipeline bugs and improve the validation #1486
Merged
+81
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juicer <[email protected]>
|
@benjaminhuo Can you please help review this MR again? Sorry but I didn't manage to fix the DCO issue in the last pr. created this one and improve the detials. Testing run in my fork: |
This was referenced Feb 28, 2025
Closed
joshuabaird
approved these changes
Mar 5, 2025
Not really because no high level idea change, just some improvement. |
benjaminhuo
approved these changes
Mar 6, 2025
Awesome！ Thanks @cw-Guo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Just noticed that the target release branch name is release-x.y (release-3.3), instead of release-vx.y.z, updated the naming in the pipeline to be aligned with the current naming convention.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: