Use Bundler to manage gem dependencies #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
errm
commented
Mar 19, 2018
errm
commented
- Makes builds more deterministic
- Avoids issues with plugin incompatibility with fluentd version
- Vulnerability scanning from github
- ~ moves a little closer to solving Re-design how Fluentd should be deployed as a Daemonset #43 perhaps
- Fixes Install via Gemfile? #27
|
Also fixes #69 |
errm
force-pushed
the
bundler
branch
2 times, most recently
from
b428c7f
to
e52da1e
Compare
|
@repeatedly any comments on using Bundler instead of gem utility ? |
|
Gemfile based plugin management is easier than list of install command. |
|
I am working on rebasing this PR on the recent changes ... |
errm
force-pushed
the
bundler
branch
2 times, most recently
from
45a9b43
to
8d7efe6
Compare
* Makes builds more deterministic * Avoids issues with plugin incompatibility with fluentd version * Vulnerability scanning from github * ~ moves a little closer to solving fluent#43 perhaps * Fixes fluent#27 Signed-off-by: Ed Robinson <[email protected]>
Signed-off-by: Ed Robinson <[email protected]>
|
Rebase seems good... I had to add git to the build process to cover the gems that are now being installed from git repos. @edsiper could you take another look? |
|
@edsiper Do you have any concern? We need to release v1 based images so need to merge this change before. |
|
@edsiper Can we merge? |
|
No counter opinion. Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.