Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frozen_string_literal: true in order to suppress 'warning: literal string will be frozen in the future' #4599

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
To supress warning: literal string will be frozen in the future,
we will require to fix with following proposals.

  1. Add # frozen_string_literal: true in the beginning of the file
  2. Add # frozen_string_literal: false in the beginning of the file
  3. Add RUBYOPT="-disable=frozen_string_literal" as launch option

These suggestions may be combined.

This PR adds # frozen_string_literal: true to all required files.
Seems CI will be passed,
however, Fluentd might raise FrozenError exception by unexpected frozen string
if it has not sufficient test suites...

Related to GH-4585

Docs Changes:

Release Note:

@ashie
Copy link
Member

ashie commented Aug 16, 2024

Thanks for clarifying the issue!
Once Ruby's direction is clearer, we'll determine on our direction.

@ashie ashie added the pending To be done in the future label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending To be done in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants