Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

keith-hall
Copy link

Hi,

Thanks for this useful wrapper library. I have updated the build instructions in the readme slightly, to make it easier to understand, and fixed the URL to Oniguruma.

I have also tweaked the console test program to accept (optional) arguments to tell it what regex and what text to match and which position to start from. If there are no arguments, it uses the original text and pattern, so it can be used exactly like it was before. I also changed it to output the capture group matches. I believe these changes help to make the application useful for making small manual tests of Onigmo without detracting from the original purpose of verifying that the Onigmo dll can be loaded.

In an attempt to make the API slightly easier to understand for newcomers, I also added some doc comments that were missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant