Skip to content

Conversation

zmrlft
Copy link
Contributor

@zmrlft zmrlft commented Sep 23, 2025

Prerequisite: Please merge the PR #5252 first.

Ⅰ. Describe what this PR does

This PR migrates runtime-related pages and logic, specifically:

  • Migrating all contents under the pages/runtimes/ directory

The change only affects runtime-related pages and functionalities.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases are added in this PR. The verification will focus on the normal rendering of runtime-related pages and the availability of core functionalities (view details, navigate to Workload interface, scale operations), which can be validated through manual testing as described in the verification steps.

Ⅳ. Describe how to verify it

  1. Add the necessary labels to all runtime CRDS
# Example command to add label to Fluid AlluxioRuntime CRD
kubectl patch crd alluxioruntimes.data.fluid.io --patch '{"metadata":{"labels":{"kubesphere.io/resource-served": "true"}}}'
  1. Run yarn dev to start the application
  2. Since specific pages (dataload pages) are missing, some route references may cause compilation or runtime errors (e.g., "module not found"). This is an expected behavior. During test verification, you can simply comment out the line of code that triggers the error; this issue will be fixed in subsequent PRs for page migration.
  3. Access runtime-related pages and verify that they render correctly without obvious errors
  4. Test core functionalities:
    • View runtime detail pages
    • Click on runtime status to verify navigation to the corresponding Workload interface
    • Test scaling functionality (scale up/down)
    • Verify that all these operations work as expected

Ⅴ. Special notes for reviews

  • Reviewers should focus on whether runtime-related pages render correctly and if navigation and scaling functionalities work properly

Copy link

Copy link

fluid-e2e-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

fluid-e2e-bot bot commented Sep 24, 2025

Hi @zmrlft. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant