Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(obico): remote access page refresh #1176

Closed
wants to merge 1 commit into from
Closed

docs(obico): remote access page refresh #1176

wants to merge 1 commit into from

Conversation

kennethjiang
Copy link
Contributor

We have added a lot of stuff since the last update, including the full remote access to fluidd page.

pedrolamas
pedrolamas previously approved these changes Sep 16, 2023
View reviewed changes
@pedrolamas pedrolamas requested a review from matmen September 16, 2023 14:29
@pedrolamas pedrolamas added the Docs - Enhancement Pertaining improvements or suggestions for the Docs label Sep 16, 2023
@kennethjiang
Copy link
Contributor Author

Thank you @pedrolamas !

@pedrolamas
Copy link
Member

Thank you @kennethjiang , can you please add a footer to the main PR comment with a "Signed-off-by" line, following the CONTRIBUTING guidelines.

@kennethjiang
feat: Obico remote access page refresh.
458a4fb 
Obico remote access refreshed as we have added a bunch of things since the last update. :)

Signed-off-by: Kenneth Jiang <[email protected]>
@kennethjiang
Copy link
Contributor Author

Thank you @kennethjiang , can you please add a footer to the main PR comment with a "Signed-off-by" line, following the CONTRIBUTING guidelines.

Sorry for not following the guideline! Just amended the commit.

@matmen matmen changed the base branch from master to develop September 21, 2023 08:00
@matmen matmen dismissed pedrolamas’s stale review September 21, 2023 08:00

The base branch was changed.

@pedrolamas pedrolamas changed the title Obico remote access page refresh docs(obico): remote access page refresh Sep 21, 2023
@pedrolamas pedrolamas changed the base branch from develop to master September 21, 2023 08:15
pedrolamas
pedrolamas requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @kennethjiang but we are having trouble merging this PR as the changes need to be done on the "develop" branch and not on the "master" branch.

It will probably be easier for you to close this PR, change to "develop" branch, make the changes there, push to a new PR, and then we can merge it down.

@kennethjiang
Copy link
Contributor Author

Sorry for the delay. Opened #1187. Let me know if that PR works @pedrolamas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrolamas pedrolamas pedrolamas requested changes

@matmen matmen Awaiting requested review from matmen

Assignees
No one assigned
Labels
Docs - Enhancement Pertaining improvements or suggestions for the Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennethjiang @pedrolamas