Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new cache false option. Faster streaming #1

Merged
merged 2 commits into from
May 30, 2018
Merged

Use new cache false option. Faster streaming #1

merged 2 commits into from
May 30, 2018

Conversation

arj03
Copy link
Contributor

@arj03 arj03 commented May 28, 2018

This is a "test" for flumedb/flumelog-offset#10 and dominictarr/pull-cursor#2. On my machine stream goes from around 25k/s to 30k/s.

@dominictarr
Copy link
Contributor

that's good but it should be a separate benchmark (so we can measure the impact of the cache)

@dominictarr
Copy link
Contributor

dominictarr commented May 30, 2018

I mean, separate function in the benchmark.
feel free to merge, though

@arj03
Copy link
Contributor Author

arj03 commented May 30, 2018

Right, makes sense. Thanks! Fixed and merged.

@arj03 arj03 merged commit a52a602 into master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants