-
Notifications
You must be signed in to change notification settings - Fork 18
Fix when using rpm -ivh on installation #10
base: master
Are you sure you want to change the base?
Conversation
ping @maxlapshin are these pull requests acceptable? |
Hi. All these requests must be very carefully checked. We are fighting with this rpm, because some ways of packing work on centos, other are working on suse and all this is not easy =( |
Well, this particular change should work on either if they use the same rpm base. It's an odd one because it only happens if you use -ivh (or -ih, or -Uvh, or -Uh), because that's the only place as far as I can tell where the size of the extracted rpm is checked. I can try to get a suse VM going to test if these work or not. Is there a particular version of suse you normally use? |
Okay, I setup a SUSE box,
and reran the above test
Then using this branch
|
@maxlapshin just a quick ping on these as I did test them all on SUSE and was thinking of adding a few more things, so wondering if you would consider merging, otherwise I'll probably merge on my fork and make a few more changes on top of these. |
When I install rpm's I'm in the habit of using 'rpm -ivh file.rpm' but noticed that with rpms created with this tool, I got unexpected output. Here's an example
After looking at the rpm source code and seeing it was size related I looked into how internal sizes were calculated and figured out they were not being done correctly. I found a good description here http://refspecs.linuxbase.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/pkgformat.html which had
Once I switched to these for the sizes, I got the expected output
I figure others might have similar issues.