Explicit support for folding record literals #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing, ignored test, added for flutter#150
Member
Author
|
Status: test passing locally, but failing on the GitHub bots. |
jakemac53
reviewed
Jan 12, 2026
Comment on lines
+146
to
+147
| if (psiElement instanceof DartRecord) | ||
| return PAREN_DOTS; // 14. Records |
Collaborator
There was a problem hiding this comment.
For consistency with the rest of the file:
Suggested change
| if (psiElement instanceof DartRecord) | |
| return PAREN_DOTS; // 14. Records | |
| if (psiElement instanceof DartRecord) return PAREN_DOTS; // 14. Records |
Or if it will have a line break it should probably have surrounding brackets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing, ignored test, added for #150