Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jan 7, 2026

Adds PubspecYamlUtilTest to verify pubspec parsing and file identification. Coverage verified using the Kover Gradle plugin.

Coverage Improvement:

  • PubspecYamlUtil: ~66% line coverage (33 covered, 17 uncovered).

Adds `PubspecYamlUtilTest` to verify pubspec parsing and file identification.
Coverage verified using the Kover Gradle plugin.

Coverage Improvement:
- `PubspecYamlUtil`: ~66% line coverage (33 covered, 17 uncovered).
@jwren jwren requested a review from helin24 January 7, 2026 04:29

public void testGetDartProjectName() {
myFixture.addFileToProject("pubspec.yaml", "name: my_project\n");
final VirtualFile pubspec = myFixture.findFileInTempDir("pubspec.yaml");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the PUBSPEC_YAML constant here and below?

public class PubspecYamlUtilTest extends DartCodeInsightFixtureTestCase {

public void testGetDartProjectName() {
myFixture.addFileToProject("pubspec.yaml", "name: my_project\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing newline?

@@ -0,0 +1,33 @@
package com.jetbrains.lang.dart.util;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright?

}

public void testFindPubspecYamlFile() {
myFixture.addFileToProject("pubspec.yaml", "name: my_project\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pesky newline again! :D

@pq
Copy link
Collaborator

pq commented Jan 9, 2026

Add the AI-assisted label?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants