-
Notifications
You must be signed in to change notification settings - Fork 7
Add unit tests for DartUrlResolver #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds `DartUrlResolverTest` to verify package URI resolution. Coverage verified using the Kover Gradle plugin. Coverage Improvement: - `DartUrlResolverImpl`: ~51% line coverage (48 covered, 45 uncovered).
| } | ||
|
|
||
| public void testFindFileByDartUrl() { | ||
| myFixture.addFileToProject("pubspec.yaml", "name: my_project\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the trailing newline a typo?
| public class DartUrlResolverTest extends DartCodeInsightFixtureTestCase { | ||
|
|
||
| public void testGetDartUrlForFile() { | ||
| myFixture.addFileToProject("pubspec.yaml", "name: my_project\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the trailing newline a typo?
| @@ -0,0 +1,27 @@ | |||
| package com.jetbrains.lang.dart.util; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copyright
|
Add the AI-assisted label? |
|
General comment: taking a quick scan of |
created and applied |
I saw that as well but still forged ahead here, I'm not sure what is right here, we should chat on VC. |
Adds
DartUrlResolverTestto verify package URI resolution. Coverage verified using the Kover Gradle plugin.Coverage Improvement:
DartUrlResolverImpl: ~51% line coverage (48 covered, 45 uncovered).