Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jan 7, 2026

Adds DartUrlResolverTest to verify package URI resolution. Coverage verified using the Kover Gradle plugin.

Coverage Improvement:

  • DartUrlResolverImpl: ~51% line coverage (48 covered, 45 uncovered).

Adds `DartUrlResolverTest` to verify package URI resolution.
Coverage verified using the Kover Gradle plugin.

Coverage Improvement:
- `DartUrlResolverImpl`: ~51% line coverage (48 covered, 45 uncovered).
@jwren jwren requested review from helin24 and pq and removed request for helin24 January 7, 2026 04:29
}

public void testFindFileByDartUrl() {
myFixture.addFileToProject("pubspec.yaml", "name: my_project\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing newline a typo?

public class DartUrlResolverTest extends DartCodeInsightFixtureTestCase {

public void testGetDartUrlForFile() {
myFixture.addFileToProject("pubspec.yaml", "name: my_project\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing newline a typo?

@@ -0,0 +1,27 @@
package com.jetbrains.lang.dart.util;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Copyright

@pq
Copy link
Collaborator

pq commented Jan 9, 2026

Add the AI-assisted label?

@pq
Copy link
Collaborator

pq commented Jan 9, 2026

General comment: taking a quick scan of DartUrlResolver, the file under-test, I see 5 constants and one method that are unused. I'm glad to see the test doesn't refer to those but it'd be great to remove them independently --- ideally before we generate tests?

@jwren
Copy link
Member Author

jwren commented Jan 9, 2026

Add the AI-assisted label?

created and applied

@jwren
Copy link
Member Author

jwren commented Jan 9, 2026

General comment: taking a quick scan of DartUrlResolver, the file under-test, I see 5 constants and one method that are unused. I'm glad to see the test doesn't refer to those but it'd be great to remove them independently --- ideally before we generate tests?

I saw that as well but still forged ahead here, I'm not sure what is right here, we should chat on VC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants