Add unit tests for DartNameSuggesterUtil #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `DartNameSuggesterUtilTest` to verify variable name generation logic. Coverage verified using the Kover Gradle plugin. Coverage Improvement: - `DartNameSuggesterUtil`: ~45% line coverage (23 covered, 28 uncovered).
Member
Author
|
@pq --- you were asking how we might be able to use the coverage data, see the commit message :) |
pq
reviewed
Jan 7, 2026
| assertContainsOrdered(DartNameSuggesterUtil.generateNames("_private"), "private"); | ||
| } | ||
|
|
||
| private void assertContainsOrdered(Collection<String> actual, String... expected) { |
Collaborator
There was a problem hiding this comment.
Consider removing in favor of using the already existent assertOrderedEquals in UsefulTestCase?
pq
approved these changes
Jan 7, 2026
Collaborator
Cool. Thanks! |
pq
requested changes
Jan 7, 2026
Collaborator
pq
left a comment
pq
left a comment
There was a problem hiding this comment.
Actually, it looks like this class is unused.
We'd get 100% coverage by removing it! :D
Collaborator
|
Additional feedback: maybe consider adding something to your prompt that checks for usages first? Or maybe we consider another sweep of dead code? It'd be a drag to add a bunch of tests for unused functionality; better to remove it altogether IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
DartNameSuggesterUtilTestto verify variable name generation logic. Coverage verified using the Kover Gradle plugin.Coverage Improvement:
DartNameSuggesterUtil: ~45% line coverage (23 covered, 28 uncovered).