Skip to content

Add unit tests for PubspecYamlUtil.java #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add unit tests for PubspecYamlUtil.java #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions third_party/src/test/java/com/jetbrains/lang/dart/util/PubspecYamlUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package com.jetbrains.lang.dart.util;
Copy link
Collaborator

@pq pq Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright?

Copy link
Collaborator

@pq pq Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Aside: we should consider a presubmit check here.)


import com.intellij.openapi.application.WriteAction;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.PsiFile;
import com.jetbrains.lang.dart.DartCodeInsightFixtureTestCase;
import java.io.IOException;

public class PubspecYamlUtilTest extends DartCodeInsightFixtureTestCase {

public void testIsPubspecFile() {
Copy link
Collaborator

@pq pq Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider sorting?

VirtualFile file = myFixture.configureByText("pubspec.yaml", "name: foo").getVirtualFile();
assertTrue(PubspecYamlUtil.isPubspecFile(file));

VirtualFile file2 = myFixture.configureByText("foo.yaml", "name: foo").getVirtualFile();
assertFalse(PubspecYamlUtil.isPubspecFile(file2));
}

public void testGetDartProjectName() {
VirtualFile file1 = myFixture.configureByText("pubspec.yaml", "name: my_app").getVirtualFile();
assertEquals("my_app", PubspecYamlUtil.getDartProjectName(file1));

VirtualFile file2 = myFixture.configureByText("pubspec2.yaml", "name: other_app").getVirtualFile();
assertEquals("other_app", PubspecYamlUtil.getDartProjectName(file2));

VirtualFile file3 = myFixture.configureByText("pubspec3.yaml", "invalid: yaml").getVirtualFile();
assertNull(PubspecYamlUtil.getDartProjectName(file3));

VirtualFile file4 = myFixture.configureByText("pubspec4.yaml", "name: \n nested: map").getVirtualFile();
assertNull(PubspecYamlUtil.getDartProjectName(file4));
}

public void testFindPubspecYamlFile() throws IOException {
VirtualFile pubspec = myFixture.configureByText("pubspec.yaml", "name: foo").getVirtualFile();
VirtualFile libDir = myFixture.getTempDirFixture().findOrCreateDir("lib");
VirtualFile file = myFixture.addFileToProject("lib/foo.dart", "").getVirtualFile();

assertEquals(pubspec, PubspecYamlUtil.findPubspecYamlFile(getProject(), file));
assertEquals(pubspec, PubspecYamlUtil.findPubspecYamlFile(getProject(), libDir));
assertEquals(pubspec, PubspecYamlUtil.findPubspecYamlFile(getProject(), pubspec));

WriteAction.run(() -> pubspec.delete(this));
assertNull(PubspecYamlUtil.findPubspecYamlFile(getProject(), libDir));
}
}
Loading