Skip to content

[build] migrate build dep from community to intellijIdea #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pq merged 5 commits into from
Jan 27, 2026
Merged

[build] migrate build dep from community to intellijIdea #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ff98bb
[build] migrate build dep from community to intellijIdea
pq Jan 13, 2026
cc35c9b
Merge branch 'main' into build_intellijIdea
pq Jan 14, 2026
0e2ade3
skip test
pq Jan 20, 2026
9db8f12
Merge branch 'main' into build_intellijIdea
pq Jan 21, 2026
b242d70
merge main
pq Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions third_party/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ java {

dependencies {
intellijPlatform {
// intellijIdeaCommunity can be found here:
// intellijIdea can be found here:
// https://www.jetbrains.com/idea/download/other.html
intellijIdeaCommunity("2025.1.1")
intellijIdea("2025.3.1.1")

testFramework(TestFrameworkType.Platform)

Expand Down Expand Up @@ -122,7 +122,7 @@ tasks {
val dartSdkPath = System.getenv("DART_HOME")
if (dartSdkPath != null) {
val versionFile = file("${dartSdkPath}/version")
if (versionFile.exists() && versionFile.isFile()) {
if (versionFile.exists() && versionFile.isFile) {
jvmArgs("-Ddart.sdk=${dartSdkPath}")
} else {
logger.error("This directory, ${dartSdkPath}, doesn't appear to be Dart SDK path, " +
Expand Down
3 changes: 2 additions & 1 deletion third_party/src/test/java/com/jetbrains/dart/analysisServer/DartServerRenameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ public void testMethod() {
doTest("newName");
}

public void testFileRename() {
// See: https://github.com/flutter/dart-intellij-third-party/issues/219
public void skipped_testFileRename() {
PsiFile barFile = myFixture.addFileToProject("src/bar.dart",
"<info>class</info> <info>InBar</info> { <info>var</info> <info>field</info>; <error>incorrect</error>; }");
PsiFile fooFile = myFixture.addFileToProject("foo.dart", "import r'''src/bar.dart''' ;");
Expand Down
Loading