Skip to content

Conversation

@tomcra
Copy link

@tomcra tomcra commented Jan 15, 2026

This PR provides fixes for

The changes predonmently change the way that the "New Project" dialog UI is updated when the Dart SDK combobox is modified.

The current issues are documented in the linked issues.

Manual Testing included

  • Initially setting the SDK directory when it had never been set before
  • Setting the SDK directory to a different valid directory version
  • Setting the SDK directory to a different invalid directory
  • Setting the SDK directory to a different valid directory from and invalid directory
  • Creating a project under each of the above scenarios and ensuring the project file structure is created correctly

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@google-cla
Copy link

google-cla bot commented Jan 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tomcra tomcra marked this pull request as ready for review January 16, 2026 00:29
@tomcra
Copy link
Author

tomcra commented Jan 18, 2026

@helin24 or @jwren would you be able to review this pull request? Looking at other recently submitted pull requests it looks like the dart-analysis-server-tests for macos-latest fail regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant