Skip to content

fix: Update new project dialog when Dart SDK changes #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pq merged 1 commit into from
Jan 30, 2026
Merged

fix: Update new project dialog when Dart SDK changes #215

pq merged 1 commit into from
Jan 30, 2026
+36 −10

Conversation

@tomcra
Copy link
Contributor

@tomcra tomcra commented Jan 15, 2026 •
edited
Loading

This PR provides fixes for

The changes predonmently change the way that the "New Project" dialog UI is updated when the Dart SDK combobox is modified.

The current issues are documented in the linked issues.

Manual Testing included

  • Initially setting the SDK directory when it had never been set before
  • Setting the SDK directory to a different valid directory version
  • Setting the SDK directory to a different invalid directory
  • Setting the SDK directory to a different valid directory from and invalid directory
  • Creating a project under each of the above scenarios and ensuring the project file structure is created correctly
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@google-cla
Copy link

google-cla bot commented Jan 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tomcra tomcra marked this pull request as ready for review January 16, 2026 00:29
@tomcra
Copy link
Contributor Author

tomcra commented Jan 18, 2026

@helin24 or @jwren would you be able to review this pull request? Looking at other recently submitted pull requests it looks like the dart-analysis-server-tests for macos-latest fail regularly.

@tomcra tomcra marked this pull request as draft January 30, 2026 05:29
@tomcra tomcra marked this pull request as ready for review January 30, 2026 05:29
@tomcra
Copy link
Contributor Author

tomcra commented Jan 30, 2026

Hi @pq would you be able to look at this pull request?

pq
pq approved these changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Especially thanks for the manual testing steps; we'll walk through them ourselves when we prepare the next release (fyi @helin24 and @jwren).

@pq
Copy link
Collaborator

pq commented Jan 30, 2026

Hi @pq would you be able to look at this pull request?

Sorry for the slow response on this one!

@pq pq merged commit 1b81aad into flutter:main Jan 30, 2026
9 of 10 checks passed
This was referenced Jan 30, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pq pq pq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomcra @pq