Skip to content

[analytics] improve AnalysisServerDiagnosticsAction instrumentation #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pq merged 2 commits into from
Jan 26, 2026
Merged

[analytics] improve AnalysisServerDiagnosticsAction instrumentation #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6495045
[analytics] improve `AnalysisServerDiagnosticsAction` instrumentation
pq Jan 24, 2026
24d2083
++
pq Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .../main/java/com/jetbrains/lang/dart/ide/errorTreeView/AnalysisServerDiagnosticsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.intellij.notification.Notification;
import com.intellij.notification.NotificationType;
import com.intellij.notification.Notifications;
import com.intellij.openapi.actionSystem.ActionManager;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.project.DumbAwareAction;
Expand All @@ -17,6 +18,7 @@
import com.jetbrains.lang.dart.analyzer.DartAnalysisServerService;
import org.dartlang.analysis.server.protocol.RequestError;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public class AnalysisServerDiagnosticsAction extends DumbAwareAction {

Expand All @@ -41,12 +43,10 @@ public void actionPerformed(@NotNull AnActionEvent e) {
final Project project = e.getProject();
if (project == null) return;

run(project);

Analytics.report(AnalyticsData.forAction(this, e));
run(project, e);
}

void run(final @NotNull Project project) {
void run(final @NotNull Project project, @Nullable AnActionEvent event) {
// Get the current analysis server.
DartAnalysisServerService server = DartAnalysisServerService.getInstance(project);

Expand All @@ -66,5 +66,14 @@ public void onError(RequestError requestError) {
Notifications.Bus.notify(notification);
}
});

if (event != null) {
Analytics.report(AnalyticsData.forAction(this, event));
} else {
ActionManager actionManager = ActionManager.getInstance();
if (actionManager != null) {
Analytics.report(AnalyticsData.forAction(actionManager.getId(this), project));
}
}
}
}
2 changes: 1 addition & 1 deletion ...c/main/java/com/jetbrains/lang/dart/ide/errorTreeView/DartAnalysisServerSettingsForm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ protected void hyperlinkActivated(final @NotNull HyperlinkEvent e) {
myAnalysisDiagnosticsHyperlink.addHyperlinkListener(new HyperlinkAdapter() {
@Override
protected void hyperlinkActivated(final @NotNull HyperlinkEvent e) {
new AnalysisServerDiagnosticsAction().run(myProject);
new AnalysisServerDiagnosticsAction().run(myProject, null);
}
});
}
Expand Down
Loading