Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Migrate FlutterEngineGroup to ARC #55503

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Sep 28, 2024

This migrates FlutterEngineGroup to automatic reference counting. It also migrates enginesCreatedCount from an ivar to property syntax.

I'll look at migrating engine from NSMutableArray<NSValue*> to a weak pointer array in a followup patch since it's orthogonal to ARC migration.

Issue: flutter/flutter#137801

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I secretly hope people will start referring to me as the dARC knight.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This migrates FlutterEngineGroup to automatic reference counting. It
also migrates `enginesCreatedCount` from an ivar to property syntax.

In a followup cleanup, I'll look at migrating engine from
`NSMutableArray<NSValue*>` to a weak pointer array.

Issue: flutter/flutter#137801
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants