-
Couldn't load subscription status.
- Fork 3.5k
[various] Migrate example Radio groups to new RadioGroup API #10155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 32 commits
32a6914
64064df
157a932
8109fb3
bc09c33
dfc6124
57f7be9
7b2db36
fe84be7
b813cf9
5bcf490
c6cdb22
f6b2de3
09df509
7b2347e
6c5c615
3234a2b
aaba578
5e347e4
3ded134
2a923fe
71f6c80
0839417
eceac1f
39e0367
ddc19d5
764aef8
abda454
587bbde
5e92e4b
a0f6243
ed108d7
7c0ca21
8eba7ed
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| ## NEXT | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same applies here; the changes aren't to lib/main.dart. |
||
|
|
||
| * Updates examples to use the new RadioGroup API instead of deprecated Radio parameters. | ||
| * Updates minimum supported SDK version to Flutter 3.29/Dart 3.7. | ||
|
|
||
| ## 0.3.7 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexskobozev @stuartmorgan-g this note in the changelog and updated readme seems to be out of sync with the
sdk: ^3.7.0constraint in thecamera/pubspec.yaml.This camera
0.11.2+1plugin release shows up asUpgradablein a Flutter project that hassdk: 3.8.1constraint (i.e. requires to support Android 21).If the
cameraplugin dropped support for Android 21 - it should not be upgradable and maybe plugin's sdk constraint need to be bumped to Dart 3.9?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to comment on PRs instead of filing issues when you believe there's an issue, please use the relevant PR (which is #9851 here, not this one).
Your concern is addressed in the description of that PR:
Yes, that is correct. 0.11.2+1 will work correctly in a project that supports Android 21.
"Support" here refers to the camera plugin holistically, not the
camerapackage specifically, and is not the same thing as "runs on". If someone files an issue today about an issue that happens when usingcamera*only on Android 21-23, we would close that issue saying that we no longer support Android <24, and thus, Android <24 is not supported.We deliberately do not go into a lot of details about the specific runtime support matrix of each sub-package, because that's way to much information for the README, and the resolver will ensure that the right thing happens regardless. If someone really wants that level of detail, they can read the individual pubspecs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan-g I commented on this PR because it triggered the plugin release.
I realize that older platform plugins are pulled instead. Though for consistency with federated platform plugins the
cameraplugin might be better use the same sdk constraint because this note in the changelog is misleading about Android 21 support. The camera example project also has sdk 3.9 constraint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I'm asking you to please not do that. The only reason I—the person who this comment was relevant to—saw this question is because I happened to have reviewed this PR. Meanwhile it's spamming a random contributor who has nothing to do with the thing you are asking about.
In general, it is a much better idea to report issues or potential issues via the issue tracker. There is a system for routing them to the right people, instead of just hoping that the right person sees the comment.
Anyone maintaining a federated plugin is welcome to manage their constraints however they choose to. For our plugins, we follow our documented policy of not adding artificial restrictions.