[tool] Change gradle-check logic to enforce alignment of java versions and a minimum (17) #10206
Conversation
…va version alignment
reidbaker
requested review from
ash2moon,
bparrishMines,
camsim99,
gmackall,
mboetger and
tarrinneal
as code owners
reidbaker
removed request for
ash2moon,
bparrishMines,
camsim99,
gmackall,
mboetger and
tarrinneal
gmackall
changed the title
| '$indentation${minimumJavaVersionError.split('\n').join('\n$indentation')}'); | ||
| return false; | ||
| } | ||
| if (!javaVersions.every((String element) => element == '$version')) { |
There was a problem hiding this comment.
I would strongly prefer making this the first check instead of the second, since if you don't already know there's going to be a check that they all match, the check above that only the first element is the right version seems wrong.
There was a problem hiding this comment.
Yeah I can make this change :) standby
There was a problem hiding this comment.
It's still second; I would put this before line 465's check.
| '$indentation${minimumJavaVersionError.split('\n').join('\n$indentation')}'); | ||
| return false; | ||
| } | ||
| if (!javaVersions.every((String element) => element == '$version')) { |
There was a problem hiding this comment.
It's still second; I would put this before line 465's check.
|
@stuartmorgan-g I misunderstood what ordering you wanted changed in. I thought you wanted the alignment and minimum checks to happen before the namespace and other checks. Changed to validate alignment before value and fixed a test setup that failed as a result. |
reidbaker
added
the
autosubmit
…va versions and a minimum (17) (flutter/packages#10206)
…va versions and a minimum (17) (flutter/packages#10206)
2 participants
Hold review/merge until #10201 has merged.
This pr is code review feedback from #10201 (comment)
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).