Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] Add verticalScrollBarEnabled function #8174

Conversation

JerryKhw
Copy link

@JerryKhw JerryKhw commented Nov 25, 2024

This was implemented because a scrollbar disable function was needed.

flutter/flutter#62464

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@cbracken
Copy link
Member

Hi @JerryKhw, thanks for your contribution.

Looks like the Dart code fails analysis:

warning - lib/src/webkit_webview_controller.dart:521:16 - The method doesn't override an inherited method. Try updating this class to match the superclass, or removing the override annotation. - override_on_non_overriding_member
   info - lib/src/webkit_webview_controller.dart:521:16 - Missing documentation for a public member. Try adding documentation for the member. - public_member_api_docs

On the iOS side, looks like there are build errors:

Xcode build done.                                           30.4s
Failed to build iOS app
Error (Xcode): ../lib/src/webview_controller.dart:411:21: Error: The method 'verticalScrollBarEnabled' isn't defined for the class 'PlatformWebViewController'.

You'll also need to add tests to ensure that the new behaviour doesn't get regressed by future patches.

I'm going to mark this as a draft PR for now. Once you've resolved these issues and all checkboxes in the above list are ticked, please mark as ready for review and we'll take a look.

@cbracken cbracken marked this pull request as draft November 26, 2024 18:05
@JerryKhw JerryKhw force-pushed the feature/webview_flutter/scrollbar_enabled branch from 0acab80 to fad9930 Compare November 27, 2024 20:41
@JerryKhw JerryKhw force-pushed the feature/webview_flutter/scrollbar_enabled branch from fad9930 to 49f57ba Compare November 27, 2024 20:57
@goderbauer
Copy link
Member

(triage): @JerryKhw Do you still have plans to come back to this PR to get it out of its draft state into a reviewable form?

@bparrishMines
Copy link
Contributor

@JerryKhw The update to the native wrapper on iOS has been landed: #8311. If you choose to continue working on this, it may be easier to start the iOS portion from scratch. It should be as easier to update the wrapper now though.

@JerryKhw
Copy link
Author

@goderbauer @bparrishMines
Hello.
There is currently some work in progress, so it looks like there will be work again after March.

@Piinks
Copy link
Contributor

Piinks commented Apr 2, 2025

Hey @JerryKhw! Happy April! :)
Would you like to continue working on this change?

@bparrishMines
Copy link
Contributor

@JerryKhw I was able to take this over and created #9024 from this branch. Closing in favor of #9024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants