-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Add verticalScrollBarEnabled function #8174
[webview_flutter] Add verticalScrollBarEnabled function #8174
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Hi @JerryKhw, thanks for your contribution. Looks like the Dart code fails analysis:
On the iOS side, looks like there are build errors:
You'll also need to add tests to ensure that the new behaviour doesn't get regressed by future patches. I'm going to mark this as a draft PR for now. Once you've resolved these issues and all checkboxes in the above list are ticked, please mark as ready for review and we'll take a look. |
0acab80
to
fad9930
Compare
fad9930
to
49f57ba
Compare
(triage): @JerryKhw Do you still have plans to come back to this PR to get it out of its draft state into a reviewable form? |
@goderbauer @bparrishMines |
Hey @JerryKhw! Happy April! :) |
This was implemented because a scrollbar disable function was needed.
flutter/flutter#62464
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.