[in_app_purchase] add Storefront.countryCode() and AppStore.sync() #8900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
hellohuanlin
reviewed
Apr 2, 2025
| let error = PigeonError( | ||
| code: "storekit2_failed_to_fetch_country_code", | ||
| message: "Storekit has failed to fetch the country code.", | ||
| details: "Storekit has failed to fetch the country code.") |
There was a problem hiding this comment.
is details optional? can we pass nil?
| details: "Storekit has failed to fetch the country code.") | ||
| return completion(.failure(error)) | ||
| } | ||
| return completion(.success(currentStorefront.countryCode)) |
There was a problem hiding this comment.
this is a weird way to write it - it's returning whatever to be returned from completion closure, which is Void.
| do { | ||
| try await AppStore.sync() | ||
| } catch { | ||
| fatalError("Failed to sync to the AppStore: \(error)") |
There was a problem hiding this comment.
shouldn't it complete with error rather than crash?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#159631 and fixes flutter/flutter#165659
Adds iap support for accessing store front country code and manual transaction syncing.
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).