Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview_flutter] Skip flaky legacy tests on iOS #8911

Merged
merged 1 commit into from
Mar 31, 2025
Merged

[webview_flutter] Skip flaky legacy tests on iOS #8911

merged 1 commit into from
Mar 31, 2025
+111 −98

Conversation

vashworth
Copy link
Contributor

I previously skipped these tests in webview_flutter_wkwebview example app (#8895), but need to also skip in the webview_flutter example app.

Temporary solution for flutter/flutter#164632.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under1.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

Sorry, something went wrong.

@vashworth vashworth requested a review from cbracken as a code owner March 26, 2025 22:52
@vashworth vashworth requested review from bparrishMines and removed request for cbracken March 26, 2025 22:52
@vashworth vashworth requested a review from cbracken March 27, 2025 19:27
@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2025
@auto-submit auto-submit bot merged commit be0e0e2 into flutter:main Mar 31, 2025
82 checks passed
vashworth added a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@vashworth
[webview_flutter] Skip flaky legacy tests on iOS (flutter#8911)
89a6cd5 
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter#8895), but need to also skip in the `webview_flutter` example app.

Temporary solution for flutter/flutter#164632.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma

@bparrishMines bparrishMines

@cbracken cbracken

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vashworth @loic-sharma